Change amc plugin interface to take item_ids list instead of filter #5929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
roxy-dao
approved these changes
Jan 8, 2025
|
@andreievg happy for me to merge this or are you wanting to keep that base clean? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5826
👩🏻💻 What does this PR do?
Removes the ItemStatsFilter type, replacing my a list of item_ids
This makes the calling service for the AMC Plugin simplier and less risk of changes not being covered correctly.
💌 Any notes for the reviewer?
This means that callers of item_stats will need to know the items in advance but that seems to be the case in all our use cases.
🧪 Testing
📃 Documentation
1.
2.