5828.1 Backend provision for uploading and installing plugin #5924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
andreievg
changed the title
…n-for-uploading-and-installing-plugin
jmbrunskill
approved these changes
Jan 9, 2025
| #[error("Failed to open manifest file {0}")] | ||
| CannotOpenManifestFile(PathBuf, #[source] std::io::Error), | ||
| #[error("Failed to parse manifest file {0}")] | ||
| CannotManifestFile(PathBuf, #[source] serde_json::Error), |
There was a problem hiding this comment.
Suggested change
| CannotManifestFile(PathBuf, #[source] serde_json::Error), | |
| CannotReadManifestFile(PathBuf, #[source] serde_json::Error), |
|
|
||
| // This endpoint can be use for uploading files before they need to be processed (via graphql endpoint) | ||
|
|
||
| #[post("/upload")] |
There was a problem hiding this comment.
Suggested change
| #[post("/upload")] | |
| #[post("/config_upload")] |
Note sure the best wording but I think upload is a bit too generic...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5828
👩🏻💻 What does this PR do?
Limited info is returned currently by uploadedPluginInfo endpoint, the idea is it would be indicator to the user of what will be imported (didn't want to expand too much atm)
💌 Any notes for the reviewer?
Versioning will be added at some point, similar to report where report id would be code + version), this would be done by bundler
There is still a follow up PRs for
1 - Frontend UI for importing plugins
2 - Binding plugins via processors (so that after sync it's available) and on startup
3 - Versioning
🧪 Testing
Go through tests in amc.js, and see how it effects database (with backend_plugin table and amc calulcation).
📃 Documentation
1.
2.