This library is very needlessly slow #10
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some major places where performance could be improved. I could see this library being easily 2-3x faster. For example, NSMutableArray is a no-no for performance critical code. Instead, we should be using a C array, preferably a preallocated thread-safe scratch buffer, and then create an NSArray from that. This is just one example of the sort of issues. This code base is written in what would be considered good Objective-C style, but that simply won't do for something like serialization, where performance is crucial.
This is a trivial PR to act as an issue, because I don't know how else to surface this systemic problem with the code base.