Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This library is very needlessly slow #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michaeleiselsc
Copy link

There are some major places where performance could be improved. I could see this library being easily 2-3x faster. For example, NSMutableArray is a no-no for performance critical code. Instead, we should be using a C array, preferably a preallocated thread-safe scratch buffer, and then create an NSArray from that. This is just one example of the sort of issues. This code base is written in what would be considered good Objective-C style, but that simply won't do for something like serialization, where performance is crucial.

This is a trivial PR to act as an issue, because I don't know how else to surface this systemic problem with the code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant