[WIP] Add add support for Timestamp type #431
Conversation
| @@ -32,6 +32,8 @@ | |||
| import java.nio.charset.CharsetEncoder; | |||
| import java.nio.charset.CoderResult; | |||
| import java.nio.charset.CodingErrorAction; | |||
| import java.time.Instant; | |||
There was a problem hiding this comment.
drop Java 7 support ?
Lines 12 to 13 in 81d540d
There was a problem hiding this comment.
@frsyuki has confirmed it works in Java6 and Java7 even if Instant class is in the import statement. Only programs that use Instance related methods will fail to compile.
|
TODO:
|
|
How is the timestamp feature coming along? I know the msgpack-js project is getting close to a release: kawanet/msgpack-lite#76 |
|
@mattbishop We haven't decided how to add above two things; whether to add MessageFormat In the msgpack spec, timestamp is just one of the Extention types. We think adding these two additional types will be convenient for timestamp users. However, adding these types is a big change to the API (since most of the users is using switch case statement for checking data type, so rewriting will be necessary by adding |
| return sec * 1000L + nsec / 1000L; | ||
| } | ||
| case 12: { | ||
| int nsec = readInt(); |
There was a problem hiding this comment.
@frsyuki nsec is uint32, so &xffffffffL mask is necessary to convert negative int32 to uint32
| } | ||
| switch (ext.getLength()) { | ||
| case 4: { | ||
| int u32 = readInt(); |
There was a problem hiding this comment.
@frsyuki Need to convert to uint32 by applying 0xFFFFFFFFL mask
| return Instant.ofEpochSecond(sec, nsec); | ||
| } | ||
| case 12: { | ||
| int nsec = readInt(); |
There was a problem hiding this comment.
This also needs to be converted to uint32 with 0xFFFFFFFFL mask
|
Hi there, any progress on this feature? |
|
Continuing the work at #565 |
|
Closing this PR in favor of #565 |
Implementation is still working in progress.
Here is the spec of the new timestamp type: msgpack/msgpack#209