Expose packing and unpacking primitives #34
+64
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fromString f ... == fromString ... . f - no need to transform the data inside
msgpack/Data/MessagePack/Pack.hs
Outdated
|
|
||
| instance Packable B.ByteString where | ||
| from = fromString id B.length fromByteString | ||
| from = fromString B.length fromByteString . id |
There was a problem hiding this comment.
Haha, true! I did this transformation quite mechanical. Added fix to pull request.
|
This seems reasonable to me, no reason not to expose functions if they might be of use to people. @tanakh, what do you think? |
|
Any update on this? It would be awesome to have it on hackage. |
|
This still looks good to me. I can merge it into github, but I don't have the ability to put it on Hackage and it seems strange to have github master not track Hackage relatively closely. Sorry for the delay, I don't know where @tanakh, is. |
christian-marie
pushed a commit
to christian-marie/pill-bug
that referenced
this pull request
Dec 3, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to write some
PackableandUnpackableinstances for my own data structure and for this found the primitives in the package very useful. Unfortunately, they are not exposed, so that I had to copy-pasted them into my project.This pull request exports:
fromString,fromArray,fromPair,fromMapfromData.MessagePack.UnpackparseString,parseArray,parsePair,parseMap,parseUint16,parseUint32,parseUint64,parseInt8,parseInt16,parseInt32,parseInt64fromData.MessagePack.PackIt also adds Haddocks to all exported functions.