Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication & Authorization #4

Open
wants to merge 63 commits into
base: master
Choose a base branch
from
Open

Authentication & Authorization #4

wants to merge 63 commits into from

Conversation

mserykh
Copy link
Owner

@mserykh mserykh commented Aug 8, 2022

  1. Task
  2. Done 10.08.2022 / Deadline: 07.08.2022 23:59
  3. Self-evaluation:
    Score:
    75 - 30% = 52.5 / 170

Basic Scope

  • +30 Route /auth/signup implemented correctly, related logic is divided between controller and corresponding service
  • +15 / 30 Route /auth/login has been implemented, related logic is divided between controller and corresponding service
  • +10 User password saved into database as hash
  • +20 Access Token is implemented,JWT payload contains userId and login, secret key is saved in .env.
  • +40 Authentication is required for the access to all routes except /auth/signup, /auth/login, /doc and /.
  • +10 Separate module is implemented within application scope to check that all requests to all routes except mentioned above contain required JWT token

Advanced Scope

  • +30 Route /auth/refresh implemented correctly, related logic is divided between controller and corresponding service

Forfeits

  • -10 for each failing test with npm run test:auth (this forfeit applied once if coincides with same forfeit in different assignments in case there are multiple assignments in task)
  • -30% of max task score Commits after deadline, except commits that affect only Readme.md, .gitignore, etc.(this forfeit applied once if coincides with same forfeit in different assignments in case there are multiple assignments in task)
  • -20 Missing PR or its description is incorrect
  • -20 No separate development branch
  • -20 Less than 3 commits in the development branch, not taking into account commits, making changes only in Readme.md or similar files (tsconfig.json, .gitignore, .prettierrc.json, etc.)

@mserykh mserykh changed the title Feat/auth Authentication & Authorization Aug 8, 2022
@mserykh mserykh mentioned this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants