Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST Service: Basic #1

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

REST Service: Basic #1

wants to merge 30 commits into from

Conversation

mserykh
Copy link
Owner

@mserykh mserykh commented Jul 12, 2022

  1. Task
  2. Screenshot: N /A
  3. Deploy: N /A
  4. Done: 17.07.2022 17:57 / Deadline: 17.07.2022 23:59
  5. Score: 750 / 750

NB!
Please note that there is a commit to tests which was added by the original repo creator. Please see screenshots:
40a7be8ce83aba6f2bd0bc5385ec5cc5
1d680c82b8730fb8d1d114a67a5d46a7

Basic Scope

  • +10 The repository with the application contains a Readme.md file containing detailed instructions for installing, running and using the application
  • +10 The application code that worked with Users instance divided into modules according to to its purpose and Nest.js architecture conventions (work with request and response in controller, business logic in service, etc.)
  • + 10 The application code that worked with Tracks instance instance divided into modules according to to its purpose and Nest.js architecture conventions (work with request and response in controller, business logic in service, etc.)
  • + 10 The application code that worked with Albums instance instance divided into modules according to to its purpose and Nest.js architecture conventions (work with request and response in controller, business logic in service, etc.)
  • + 10 The application code that worked with Artists instance instance divided into modules according to to its purpose and Nest.js architecture conventions (work with request and response in controller, business logic in service, etc.)
  • + 10 The application code that worked with Favorites instance instance divided into modules according to to its purpose and Nest.js architecture conventions (work with request and response in controller, business logic in service, etc.)
  • +660 / 660 For each successfully passed test ( 66 / 66 tests)

Advanced Scope

  • +10 PORT value is stored into .env file
  • +20 OpenAPI spec in doc folder corresponds with assignment

Forfeits 0

  • 0 Changes in tests
  • 0 of max task score Commits after deadline (except commits that affect only Readme.md, .gitignore, etc.)
  • 0 No separate development branch
  • 0 No Pull Request
  • 0 Pull Request description is incorrect
  • 0 Every lint error after npm run lint using local config (errors, not warnings)
  • 0 Less than 3 commits in the development branch, not including commits that make changes only to Readme.md or similar files (tsconfig.json, .gitignore, .prettierrc.json, etc.)

@mserykh mserykh changed the title Basic REST Service: Basic Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants