Use three args open #122
Open
Use three args open #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix mschilli#113 Prefer using three args open over the two args form.
mohawk2
requested changes
Jan 15, 2023
| @@ -10,7 +10,7 @@ die "usage: $0 version" unless $version =~ /^[\d.]+\w+$/; | |||
|
|
|||
| system "git checkout gh-pages" and die $!; | |||
|
|
|||
| open FILE, "<$IDX" or die "Cannot open $IDX"; | |||
| open FILE, "<", "$IDX" or die "Cannot open $IDX"; | |||
There was a problem hiding this comment.
"$IDX" isn't right. Could you fix the various instances of this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #113
Prefer using three args open over the two args form.
view extended smoker run using changes from #121
at https://github.com/atoomic/log4perl/actions/runs/3492815436