Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log::Log4perl::Appender::File is using two args open #113

Open
atoomic opened this issue Feb 2, 2022 · 2 comments · May be fixed by #122
Open

Log::Log4perl::Appender::File is using two args open #113

atoomic opened this issue Feb 2, 2022 · 2 comments · May be fixed by #122

Comments

@atoomic
Copy link
Contributor

atoomic commented Feb 2, 2022

We should consider enforcing three args open in Log4perl

this is coming from sub file_open Log::Log4perl::Appender::File

     eval {
         if($self->{syswrite}) {
             sysopen $fh, "$self->{filename}", $sysmode or
                 die "Can't sysopen $self->{filename} ($!)";
         } else {
             open $fh, "$arrows$self->{filename}" or
                 die "Can't open $self->{filename} ($!)";
         }
     };
@mohawk2
Copy link
Collaborator

mohawk2 commented Jun 1, 2022

Pull requests welcome!

atoomic added a commit to atoomic/log4perl that referenced this issue Nov 17, 2022
Fix mschilli#113

Prefer using three args open over the two args
form.
@atoomic atoomic linked a pull request Nov 17, 2022 that will close this issue
@atoomic
Copy link
Contributor Author

atoomic commented Nov 17, 2022

@mohawk2 just sent a PR with these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants