-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for auth-agent (server) #781
base: master
Are you sure you want to change the base?
Conversation
Ok, i ended up doing it \o/ This PR relies on a requirement PR in ssh2-stream |
All good since mscdex/ssh2-streams#132 has landed (just rebased it) |
I've updated the PR with requested changes |
Also can you add a test for this? I understand it will (currently) require the master |
I've updated the PR again, (with the style change - sorry for that). I'm looking into the "test" part now |
So, testing the agent stream requires me to spawn a "real" ssh-agent. Is that okay with you ? |
Do we really need |
I've updated the PR with ssh-streams2 bump (as this is needed) so the tests can pass. I've spend some time on it, but i cannot find a way to test openssh_authAgent without running a proper agent server. If spawning an external server bother you, i've wrote a pure js ssh-agent server, but that's another story. Also, this PR is working fine under WSL (as i'm working only on this stack) |
I'll rebase that for 1@ |
Hi @mscdex , is there anything more you want on this one ? |
1efa86c
to
40fa58f
Compare
Hi @mscdex, is there any other problem with this pull request? i'm implementing a ssh proxy and this feature is required to implement public key login on destination. i also tested changes on my local env and its working |
The
[email protected]
channel is not implemented on the server side.The server need to acknowledge the request by opening a channel (see openssh source code )
Again, this is an amazing project and i'm very excited being able to help, even if it's just a little.