[TASK] TRK-474 Store Click information in Event Storage - added mutex…

… around Ticker to avoid data race. (#101)

.github/workflows/test.yaml

@@ -23,6 +23,6 @@ jobs:
         uses: ./.github/actions/external/go-test
         with:
           org_token: ${{ secrets.GH_TOKEN }}
-          lint: true
           test: true
-          vet: true
+          vet: true
+          race: false

kafka/source.go

@@ -314,7 +314,6 @@ func (s *Source) ConsumeClaim(_ sarama.ConsumerGroupSession, claim sarama.Consum
 		// - s.buf is full (but not draining, since pumps are off)
 		// - we have consumed a message and are attempting to send it to s.buf
 		case <-s.done:
-			break
 		}
 	}
 

metastore.go

@@ -90,7 +90,7 @@ func (s *metastore) PullAll() (map[Processor]Metaitems, error) {
 
 	// Make sure no marks are happening on the old metadata
 	s.procMu.Lock()
-	s.procMu.Unlock()
+	s.procMu.Unlock() //lint:ignore SA2001 syncpoint
 
 	return oldMeta, nil
 }

supervisor.go

@@ -206,6 +206,7 @@ type timedSupervisor struct {
 	t       *time.Ticker
 	commits uint32
 	running uint32
+	mutex   sync.Mutex
 }
 
 // NewTimedSupervisor returns a supervisor that commits automatically.
@@ -241,7 +242,9 @@ func (s *timedSupervisor) Start() error {
 		return ErrAlreadyRunning
 	}
 
+	s.mutex.Lock()
 	s.t = time.NewTicker(s.d)
+	s.mutex.Unlock()
 
 	go func() {
 		for range s.t.C {
@@ -267,6 +270,8 @@ func (s *timedSupervisor) Close() error {
 		return ErrNotRunning
 	}
 
+	s.mutex.Lock()
+	defer s.mutex.Unlock()
 	s.t.Stop()
 
 	return s.inner.Close()

topology.go

@@ -170,9 +170,7 @@ func nodesConnected(roots []Node) bool {
 	var visit []Node
 	connections := 0
 
-	for _, node := range roots {
-		visit = append(visit, node)
-	}
+	visit = append(visit, roots...)
 
 	for len(visit) > 0 {
 		var n Node