Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutils: fix test flake on HEAD request #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dbungert
Copy link

testutils: fix test flake on HEAD request

Flakiness may be observed when running the unit tests.
The symptom of that looks like:
requests.exceptions.ConnectionError: ('Connection aborted.',
BadStatusLine('Hello world!HTTP/1.1 200 OK\r\n'))

We believe that, with the correct send and recv timing, the "Hello
world!" body from a HEAD request will be left unread in the reused
socket, resulting in an invalid read for the next request along.

Co-authored-by: Olivier Gayot [email protected]

Flakiness may be observed when running the unit tests.
The symptom of that looks like:
requests.exceptions.ConnectionError: ('Connection aborted.',
BadStatusLine('Hello world!HTTP/1.1 200 OK\r\n'))

We believe that, with the correct send and recv timing, the "Hello
world!" body from a HEAD request will be left unread in the reused
socket, resulting in an invalid read for the next request along.

Co-authored-by: Olivier Gayot <[email protected]>
@dbungert
Copy link
Author

Testing was performed with 39b9c64 cherry-picked to the branch but is otherwise independent of that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant