bug(api)!: remove timeout code #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msabramo
force-pushed
the
remove-timeout-code
branch
from
0421f81 to
dbaaacf
Compare
msabramo
changed the title
msabramo
force-pushed
the
remove-timeout-code
branch
3 times, most recently
from
2cc0ec6 to
114cc0b
Compare
BREAKING CHANGE: Remove timeout code and `timeout` parameter from method signatures, because it gives the impression of doing something, but seems to be ineffective (see #44 (comment)). Sem-Ver: api-break
This is a UNIX domain socket server that accepts connections and never responds, so that we can test timeouts on the client side.
msabramo
force-pushed
the
remove-timeout-code
branch
from
114cc0b to
44f9fa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Remove timeout code and
timeoutparameter from method signatures, because it gives the impression of doing something, but seems to be ineffective (see #44 (comment)).Fixes: GH-44
Sem-Ver: api-break