Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work in progress PR for live previews #3

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Work in progress PR for live previews #3

merged 4 commits into from
Jul 24, 2024

Conversation

gvarnavi
Copy link
Collaborator

No description provided.

@rowanc1
Copy link
Contributor

rowanc1 commented Jul 24, 2024

It is possible that this was submitted with a different token / user, which is causing the submit to fail. I have pinged @fwkoch to investigate.

@gvarnavi
Copy link
Collaborator Author

It is possible that this was submitted with a different token / user, which is causing the submit to fail. I have pinged @fwkoch to investigate.

Thanks @rowanc1! If that's the case, I guess the easiest solution would be to override the org-level CURVENOTE_TOKEN with a repo-level one?

@rowanc1
Copy link
Contributor

rowanc1 commented Jul 24, 2024

We have some database digging to do, we will provide a way forward tomorrow morning.

@rowanc1
Copy link
Contributor

rowanc1 commented Jul 24, 2024

Two PRs incoming for fixing issues here:

@gvarnavi
Copy link
Collaborator Author

Thanks @rowanc1 and @fwkoch 🙌

Am I correct in understanding that this only affects the draft action? Meaning if this is merged into main, that action should succeed ?

@rowanc1
Copy link
Contributor

rowanc1 commented Jul 24, 2024

I think it is worth trying, the worst that happens is we get a red x over on main, and then we should have that fixed in a day or so.

@gvarnavi gvarnavi marked this pull request as ready for review July 24, 2024 14:51
@gvarnavi gvarnavi merged commit 7bef47e into main Jul 24, 2024
3 of 4 checks passed
@gvarnavi
Copy link
Collaborator Author

Indeed, the submit action seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants