Fix parameterized return types in StreamMatchers #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return type is parameterized to yield a Matcher of the specific Stream-type, instead of just Matcher<BaseStream<_, _>>. See unruly/java-8-matchers#18 for more detailed discussion.
This is peculiar. It seems the type inference through multiple levels of method invokations is better with Java 8 than Java 11. Anyway, the outermost is(..) invocation is redundant (and in my opinion also decreases readability), so they are removed to make the code compile on Java 11.
|
@mrwilson As c973640 fixes the build on OpenJDK 9 and 11 (https://travis-ci.org/github/mrwilson/java-8-matchers/builds/712914543), I suggest we also remove the |
|
I believe these changes are supposed to be backwards compatible. Did a small check with japicmp and the report did not show any breaking API-changes. |
Merged
|
I'll do a 1.9 release this weekend 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes return types for
.equalTo,.contains, and.empty.Duplicates unruly/java-8-matchers#22, which fixes unruly/java-8-matchers#18
This PR also fixes compile issues from Java 9 and later, see c973640