Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support for Windows #38

Merged
merged 13 commits into from
Sep 18, 2021
Merged

Feat: Support for Windows #38

merged 13 commits into from
Sep 18, 2021

Conversation

mrsauravsahu
Copy link
Owner

@mrsauravsahu mrsauravsahu commented Aug 19, 2021

will close #4

Testbed:
Windows 10 v21H1 (OS Build 19043.1165)
VSCode 1.59.0

Functionalities working:

  • ✔ create custom profiles
  • ✔ View featured profiles
  • ✔ Launch custom profile from 'Custom Profiles Explorer'
  • ✔ View details of a custom profile
  • ✔ Rename profile
  • ✔ Launch Custom Profile from .vscode/profile.json

Things which won't work

  • Copy alias - the command copy works but the Alias itself won't.

As the command generator is cross platform, it needs to be tested all previously working OSs

@mrsauravsahu mrsauravsahu self-assigned this Aug 19, 2021
@mrsauravsahu mrsauravsahu marked this pull request as ready for review September 18, 2021 07:25
@mrsauravsahu mrsauravsahu merged commit fb7bbd1 into cool Sep 18, 2021
@mrsauravsahu mrsauravsahu deleted the feat/platform-windows branch September 18, 2021 07:26
mrsauravsahu added a commit that referenced this pull request Jul 6, 2022
* v1.1.3: Improv: Fix audit checks & make audit check part of CI (#39)

* improv: make audit check part of CI

* fix: audit checks with npm audit fix

* bump: v1.1.3

* fix: lint command in ci.yml

* fix: lint

* docs: changelog

* v1.1.4: Fix: Dependabot alerts (#40)

* bump: axios install

* docs: changelog

* bump: v1.1.4 (#41)

* Feat: Support for Windows (#38)

* add a command generate to support command execution on different OSs

* inject all services to handlers

* fix view custom profile details

* run powershell with -NoProfile on Windows

* fix linting issues

* wip: extensions install for .vscode/profile.json

* feat: launch custom profile

* fix: rename command

* run a lint fix

* bump: v2.0.0

* use shellRecords to decide which shell to use

* docs: changelog

* Feat: Clone Profile (#45)

* wip: clone-profile

* feat: add option to choose which extensions when cloning

* fix: restore launch-profile

* fix: run a lint fix

* improv: cleanup map for installing extensions in clone profile

* 2.1.0

* Setup: CD (#37)

* install vsce package

* add script to build project

* add cd section with github actions - create VSIX as an artifact

* fix: version usage in different steps

* fix: expression syntax

* fix: command to calculate version

* fix: set APP_VERSION output

* ignore .envrc file

* add script to run vsce

* publish vscode extension through Github Actions

* split ci and cd files

* rename ci and cd jobs

* Bump: nth-check from 2.0.0 to 2.0.1 (#47)

* Bump nth-check from 2.0.0 to 2.0.1

Bumps [nth-check](https://github.com/fb55/nth-check) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/fb55/nth-check/releases)
- [Commits](fb55/nth-check@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: nth-check
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* 2.1.1

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Saurav Sahu <[email protected]>

* Fix: Audit fix & Bump Node.js to 16.13.0 (#49)

* (fix) audits

* (bump) node to lts version through nvmrc (Node Version Manager)

* (docs) split changelog to different file

* 2.1.2

* (docs) reconcile changelogs

* Feat: Support `code-insiders` (#50)

* (feat) use code or code-insiders based on where the extension is running

* 2.2.0

* [skip ci] chore: use reusable tmp github action for CI (#53)

* chore: use reusable mrsauravsahu/actions ci-vscode-extension/v0.3.0

* chore: update main branch to `main`

* 2.2.1

* bump: packages

* fix: npm audit issues

* chore: remove unused type superagent

* chore(ci): remove use of common action file

* fix: use github.ref_name

* chore(cicd): move tag/release to cd file

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Support for Windows
1 participant