Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laika and API docs #134

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Conversation

SemyonSinchenko
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko commented Aug 16, 2024

Preview

How it looks like in my fork

Comments

I think we should refactor build.sbt to lazy val and project to separate core and docs. Also it could be cool to move part of leika conf to a separate scala file. But I would do it in a separate PR better.

PS

It is the first time when I'm trying to make a website for a scala project. I tried docusaurus + mdoc but failed. From the other side Laika looks fresh, lightweight and easy to configure compared to docusaurus that requires solid js/ts knowledge.

Content

I will work with extending the documentation, updating README, etc. But I would merge the core part of docs first.

Part of #127

 On branch docs-in-ci
 Your branch is up to date with 'upstream/main'.

 Changes to be committed:
	new file:   .github/workflows/docs.yml
	modified:   README.md
	modified:   build.sbt
	new file:   docs/about/README.md
	modified:   project/plugins.sbt
@SemyonSinchenko SemyonSinchenko self-assigned this Aug 16, 2024
@SemyonSinchenko SemyonSinchenko mentioned this pull request Aug 16, 2024
5 tasks
@SemyonSinchenko SemyonSinchenko changed the title Add Leika and API docs Add Laika and API docs Aug 16, 2024
Copy link
Collaborator

@MrPowers MrPowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SemyonSinchenko SemyonSinchenko merged commit a48bf28 into mrpowers-io:main Aug 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants