Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new parameter return_bool to validate dataframe methods (fix linting) #267

Conversation

paulooctavio
Copy link
Contributor

Proposed changes

This PR addresses issue #51 by introducing a return_bool flag to the validate_presence_of_columns, validate_absence_of_columns, and validate_schema methods, enabling them to return boolean values rather than raising errors. This PR is also meant to fix the build error related ruff lint failure in PR #265.

Types of changes

What types of changes does your code introduce to quinn?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@jeffbrennan
Copy link
Collaborator

hey @paulooctavio, could you please resolve the merge conflicts? Looks good otherwise!

@jeffbrennan
Copy link
Collaborator

@paulooctavio thanks for the updates! let me know if there's anything else you would like to change before I try merging again

@paulooctavio
Copy link
Contributor Author

@jeffbrennan I think is all good now, I tested ruff lint and it passed.

@jeffbrennan jeffbrennan merged commit 9156cee into mrpowers-io:main Oct 4, 2024
9 checks passed
@jeffbrennan
Copy link
Collaborator


image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants