Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ruff UP007 #245

Merged

Conversation

fpgmaas
Copy link

@fpgmaas fpgmaas commented Jul 15, 2024

Proposed changes

Enable UP007 for this project. According to PEP563, by importing from __future__ import annotations, starting with Python 3.7 the annotations should be backwards compatible.

Types of changes

What types of changes does your code introduce to quinn?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@SemyonSinchenko
Copy link
Collaborator

@fpgmaas Thank you for the contribution! In the planning 1.0 release we dropped the support of py37 and already enabled Ruff. May you reopen this PR into the planning-1.0-release branch? The idea is that the current main accepts only fixes.

@fpgmaas fpgmaas changed the base branch from main to planning-1.0-release July 15, 2024 07:36
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SemyonSinchenko
Copy link
Collaborator

@fpgmaas Than you for your work!

@SemyonSinchenko SemyonSinchenko merged commit 1ed9375 into mrpowers-io:planning-1.0-release Jul 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants