Add difference tool to configurator #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrozycki
reviewed
May 19, 2024
krzmaz
force-pushed
the
difference-tool
branch
2 times, most recently
from
ae8ffc4 to
5961888
Compare
mrozycki
reviewed
May 19, 2024
configurator/src/cv.rs
Outdated
| if let Some(output) = &output_dir { | ||
| let mut output = output.clone(); | ||
| output.push("1_base_grayscale.jpg"); | ||
| Picture::from(base_gray.clone()).save_to_file(output.to_str().unwrap())?; |
There was a problem hiding this comment.
nit: to_str()? instead of unwrap?
mrozycki
approved these changes
May 19, 2024
mrozycki
reviewed
May 19, 2024
configurator/src/cv.rs
Outdated
| pub fn save_to_file(&self, filename: &str) -> Result<(), Box<dyn Error>> { | ||
| debug!("Writing file: {}", filename); | ||
| opencv::imgcodecs::imwrite(filename, &self.inner, &opencv::core::Vector::default())?; | ||
| pub fn save_to_file<P: AsRef<Path>>(&self, path: &P) -> Result<(), Box<dyn Error>> { |
There was a problem hiding this comment.
Suggested change
| pub fn save_to_file<P: AsRef<Path>>(&self, path: &P) -> Result<(), Box<dyn Error>> { | |
| pub fn save_to_file<P: AsRef<Path>>(&self, path: P) -> Result<(), Box<dyn Error>> { |
mrozycki
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.