Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix mode enum being a number instead of a string in codegen #754

Merged
merged 12 commits into from
Oct 22, 2024
Merged

fix: Fix mode enum being a number instead of a string in codegen #754

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e8abb5a
feat: Update MMKV core to V2
mrousavy Oct 22, 2024
bbaddbe
feat: Add `isReadOnly` prop and config
mrousavy Oct 22, 2024
1a0d4e4
chore: Lockfiles
mrousavy Oct 22, 2024
8b68653
feat: Upgrade deps
mrousavy Oct 22, 2024
6ef3066
feat: Upgrade deps in package
mrousavy Oct 22, 2024
4cd7f02
fix: Fix missing template argument for `MMKVConfig`
mrousavy Oct 22, 2024
ced80b7
fix: Add `isReadOnly` to props
mrousavy Oct 22, 2024
beafe50
feat: Throw JS Error about readonly
mrousavy Oct 22, 2024
46ca252
fix: Format
mrousavy Oct 22, 2024
1fcb95b
docs: Add `readOnly` to config docs
mrousavy Oct 22, 2024
7f9e1e0
fix: Fix `mode` enum being a number instead of a string in codegen
mrousavy Oct 22, 2024
6f97758
Merge branch 'main' into fix/enum-mode
mrousavy Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion package/src/createMMKV.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Platform } from 'react-native';
import { getMMKVTurboModule, type Configuration } from './NativeMmkv';
import { getMMKVTurboModule, Mode, type Configuration } from './NativeMmkv';
import type { NativeMMKV } from './Types';
import { getMMKVPlatformContextTurboModule } from './NativeMmkvPlatformContext';

Expand All @@ -23,6 +23,13 @@ export const createMMKV = (config: Configuration): NativeMMKV => {
}
}

if (typeof config.mode === 'number') {
// Code-gen expects enums to be strings. In TS, they might be numbers tho.
// This sucks, so we need a workaround.
// @ts-expect-error the native side actually expects a string.
config.mode = Mode[config.mode];
}

const instance = module.createMMKV(config);
if (__DEV__) {
if (typeof instance !== 'object' || instance == null) {
Expand Down
Loading