-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: android build #112
fix: android build #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're a savior for doing this! I was able to run on my Android device...might want 1 or 2 other approvals.
Note: you may need to update vision-camera-resize-plugin
awesome 🎉 these changes are working for me in expo 52 building locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If submodules are not needed anymore, then pay attention to delete the scripts in package.json that uses submodules:
git submodule
@@ -42,7 +42,7 @@ target_include_directories( | |||
PRIVATE | |||
"../cpp" | |||
"src/main/cpp" | |||
"../tensorflow/" | |||
"src/main/cpp/lib/litert/headers" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it really extract here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
035778d
to
08094e4
Compare
08094e4
to
5807fd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can litert
be used in iOS too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, looking at this more - for Android, does anything need to happen for the GPU delegates, as suggested in docs?
Thank you for making this PR. If you have any ETA in mind for this PR to merge and the new version release date, can you please let us know? This will be much appreciated. Thank you. |
Wonderful, this fixed my build issues! (Local builds, android). I did not build iOS yet. |
Let's go. Thank you! |
Summary
.so
changes introduced in version 0.76.