Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: android build #112

Merged
merged 3 commits into from
Dec 11, 2024
Merged

fix: android build #112

merged 3 commits into from
Dec 11, 2024

Conversation

bang9
Copy link
Contributor

@bang9 bang9 commented Nov 23, 2024

Summary

Copy link

@lucksp lucksp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're a savior for doing this! I was able to run on my Android device...might want 1 or 2 other approvals.

Note: you may need to update vision-camera-resize-plugin

@icarv
Copy link

icarv commented Nov 25, 2024

awesome 🎉 these changes are working for me in expo 52 building locally

Copy link

@RayanMoarkech RayanMoarkech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If submodules are not needed anymore, then pay attention to delete the scripts in package.json that uses submodules:

git submodule

@@ -42,7 +42,7 @@ target_include_directories(
PRIVATE
"../cpp"
"src/main/cpp"
"../tensorflow/"
"src/main/cpp/lib/litert/headers"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it really extract here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the headers used in TensorflowPlugin.h are extracted to this location.

image

@bang9 bang9 force-pushed the fix/android-build branch from 035778d to 08094e4 Compare November 28, 2024 10:49
@bang9 bang9 force-pushed the fix/android-build branch from 08094e4 to 5807fd9 Compare November 28, 2024 10:51
Copy link

@lucksp lucksp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can litert be used in iOS too?

Copy link

@lucksp lucksp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, looking at this more - for Android, does anything need to happen for the GPU delegates, as suggested in docs?

@kuldip-simform
Copy link

Thank you for making this PR. If you have any ETA in mind for this PR to merge and the new version release date, can you please let us know?
Currently, this is a blocker for us.

This will be much appreciated. Thank you.

@jslok jslok mentioned this pull request Dec 11, 2024
@agoransson
Copy link

agoransson commented Dec 11, 2024

Wonderful, this fixed my build issues! (Local builds, android). I did not build iOS yet.

@mrousavy mrousavy merged commit ccbe815 into mrousavy:main Dec 11, 2024
3 checks passed
@mrousavy
Copy link
Owner

Let's go. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fatal error: 'tensorflow/lite/c/c_api.h' file not found
7 participants