Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: react-native 0.76 build android #108

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bfar97
Copy link

@bfar97 bfar97 commented Nov 15, 2024

This fixes a react-native 0.76 build error on android.

@mrousavy
Copy link
Owner

nice! thx

@babldev
Copy link

babldev commented Nov 19, 2024

Confirmed this works for me. Although there's a whole dance you have to do for local testing of this react native package (maybe this is more familiar to regular react native devs).

  1. Clone this repo (I used shallow because tensorflow cloning as a submodule is extremely slow):
git clone --depth 1 --single-branch \
  --recurse-submodules --shallow-submodules
  https://github.com/mrousavy/react-native-fast-tflite react-native-fast-tflite

2: Set up the local package. Make sure to use npm install --production or else a second react instance is installed and breaks rendering:

cd react-native-fast-tflite/
npm install --production
npm prepack
npm link
cd ..
npm link react-native-fast-tflite

I wonder if the local dev flow is worth documenting anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants