Feat/improved exclude keys matching #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow for the filtering of keys nested underneath a specific key prefix, such as the use case of not wanting to include the keys present in an array when `expandArrayObjects` is set to `true`. This addresses the use case presented in #244.
…the start of a string
In a case where `excludeKeys` is set to `["arr"]`, there was a possibility that with JSON data looking like this:
```
[
{
"id": 1,
"arr": [
{
"name": "foo"
}
],
"name": {
"arr": "this should appear"
}
},
{
"id": 2,
"arr": [
{
"name": "bar"
}
],
"name": {
"arr": "this should also appear"
}
}
]
```
could potentially result in both `arr.name` and `name.arr` being excluded. By adjusting the RegExp thats being used for the matching, this fixes a potential bug that caused `name.arr` to be mistakenly excluded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background Information
excludeKeysandexpandArrayObjects#2445.1.0I have...