feat!: Remove async/await and make conversions sync #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There were no requirements within the code to have them async Signed-off-by: Sebastian Malton <[email protected]>
Nokel81
force-pushed
the
make-everything-sync
branch
from
c153d63 to
71f7b5c
Compare
|
@mrodrig can we merge this and get |
|
Hi @Nokel81, sorry for the delay in getting back to this. This PR looks great! I'll get this merged in and will update/create some documentation in preparation for releasing it in a 5.0.0 version. Hopefully I'll be able to have everything all set to publish it tonight. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Malton [email protected]
Background Information
5.0.0I have...