🔨📝 Misc improvements in tooling and doc (ITISFoundation#6478)

mrnicegyu11 · Oct 2, 2024 · 5560acd · 5560acd
1 parent 38ea07a
commit 5560acd
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/packages/models-library/Makefile b/packages/models-library/Makefile
@@ -110,14 +110,15 @@ erd-ServiceInput.svg: _erdantic
 DOWNLOADED_TEST_DATA_DIR = "$(CURDIR)/tests/data/.downloaded-ignore"
 
 .PHONY: _httpx
-_httpx: _check_venv_active
+_ensure_httpx: _check_venv_active
 	# ensures requirements installed
 	@python3 -c "import httpx" 2>/dev/null || uv pip install httpx
 
-PHONY: pull_test_data
-pull_test_data: $(DOT_ENV_FILE) _httpx ## downloads tests data from registry (this can take some time!)
-	# downloading all metadata files
+PHONY: tests-data
+tests-data: $(DOT_ENV_FILE) _ensure_httpx ## downloads tests data from registry defined in .env (time-intensive!)
+	# Downloading all metadata files ...
 	@set -o allexport; \
 	source $<; \
 	set +o allexport; \
 	python3 "$(PACKAGES_DIR)/pytest-simcore/src/pytest_simcore/helpers/docker_registry.py" $(DOWNLOADED_TEST_DATA_DIR)
+	@echo "Run now 'pytest -vv -m diagnostics tests'"
diff --git a/...ifications-library/src/notifications_library/templates/on_account_form.email.content.html b/...ifications-library/src/notifications_library/templates/on_account_form.email.content.html
@@ -4,7 +4,7 @@
 <p>Dear Support team
 
 <p>
-  We have received the following request form for an account in {{ product.display_name }} from {{ host }}
+  We have received the following request form for an account in {{ product.display_name }} from <b>{{ host }}</b>
 </p>
 
 <pre>

diff --git a/...tifications-library/src/notifications_library/templates/on_account_form.email.content.txt b/...tifications-library/src/notifications_library/templates/on_account_form.email.content.txt
@@ -1,6 +1,6 @@
 Dear Support team,
 
-We have received the following request form for an account in {{ product.display_name }} from {{ host }}:
+We have received the following request form for an account in {{ product.display_name }} from **{{ host }}**:
 
 {{ dumps(request_form) }}
 

diff --git a/scripts/maintenance/computational-clusters/autoscaled_monitor/dask.py b/scripts/maintenance/computational-clusters/autoscaled_monitor/dask.py
@@ -112,12 +112,13 @@ def _list_tasks(
 
         return dict(task_state_to_tasks)
 
+    list_of_tasks: dict[TaskState, list[TaskId]] = []
     try:
-        list_of_tasks: dict[TaskState, list[TaskId]] = await client.run_on_scheduler(
+        list_of_tasks = await client.run_on_scheduler(
             _list_tasks
         )  # type: ignore
     except TypeError:
-        rich.print(f"ERROR while recoverring unrunnable tasks using {dask_client=}")
+        rich.print(f"ERROR while recoverring unrunnable tasks using {dask_client=}. Defaulting to empty list of tasks!!")
     return list_of_tasks
-Original file line number
+Diff line change
@@ Expand Up / @@ -4,7 +4,7 @@ @@
     <p>Dear Support team
     <p>
-      We have received the following request form for an account in {{ product.display_name }} from {{ host }}
+      We have received the following request form for an account in {{ product.display_name }} from <b>{{ host }}</b>
     </p>
     <pre>
@@ Expand Down @@