Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol level pool creation fee #243

Closed
wants to merge 10 commits into from
Closed

Protocol level pool creation fee #243

wants to merge 10 commits into from

Conversation

jgur-psyops
Copy link
Contributor

Adds a per-program unique global struct administered by the program owner that controls various protocol fees.

Adds an origination fee on pool creation, denominated in SOL.

Moves add_pool_with_seed to its own file so it can more easily be compared against add_pool line-by-line.

Considerations for fe/api:

  • Adds two new accounts to the add_pool and add_pool_with_seed ixes
  • The init_global_fee_state ix runs just ONCE per program deployment, the program admin must run it after program upgrade after which the ix can be removed to save program buffer space.
  • Note that snipe of the init_global_fee_state by a bad actor is merely annoying (unless nobody notices it), the program will need to be upgraded with a new seed. We can also hard-code the MS wallet that should sign this tx to avoid that risk.

@jgur-psyops jgur-psyops mentioned this pull request Sep 5, 2024
2 tasks
@jkbpvsc
Copy link
Member

jkbpvsc commented Sep 6, 2024

Replaced by #244

@jkbpvsc jkbpvsc closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants