-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple event/root finding support #142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fairly large, but some of that is copying in the header from lostturnip (mrc-ide/lostturnip).
The idea is most easily seen in the deSolve docs: https://tpetzoldt.github.io/deSolve-forcing/deSolve-forcing.html - example 3 there. Suppose we have some system where we want to apply a change to the state of the system when it exactly hits some state - in the included example this is where a bouncing ball hits the ground (
height = 0
) we want to invert and reduce its velocity (so-v
becomesv * 0.9
).We do this by checking at the end of every step if a root is bounded, which occurs if the sign changes over the step. Then we interpolate within that step using the ODE interpolation to find the time where the event happens and apply some "action" function.
The actions can only change the state, they cannot change parameters, because we make the assumption that parameters are constant and shared among particles. So likely use of this for some problems will involve augmenting the state with some additional variables that have
d/dt = 0
. That's fine though because it keeps all mutable state within the state vector.Other than that there's not a lot more in here:
shared
andinternal
, so they can do a bunch of calculation if requiredinternal