Skip to content

Commit

Permalink
fix: compilation fixed again (stupid modules build does not recompile…
Browse files Browse the repository at this point in the history
… properly and the local build has passed twice with errors in the code :-()
  • Loading branch information
mpusz committed Nov 26, 2024
1 parent 6883e38 commit 1c4f744
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/core/include/mp-units/framework/symbol_text.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ constexpr bool is_basic_literal_character_set_char(char ch)
return ch == 0x00 || (0x07 <= ch && ch <= 0x0D) || (0x20 <= ch && ch <= 0x7E);
};

template<std::size_t N, typename InputIt>
template<typename InputIt>
constexpr bool is_basic_literal_character_set(InputIt begin, InputIt end) noexcept
{
return all_of(begin, end, is_basic_literal_character_set_char);
Expand All @@ -78,7 +78,7 @@ constexpr bool is_basic_literal_character_set(const char (&txt)[N]) noexcept
template<std::size_t N>
constexpr fixed_u8string<N> to_u8string(fixed_string<N> txt)
{
MP_UNITS_EXPECTS(is_basic_literal_character_set(txt));
MP_UNITS_EXPECTS(is_basic_literal_character_set(txt.begin(), txt.end()));
return std::bit_cast<fixed_u8string<N>>(txt);
}

Expand Down

2 comments on commit 1c4f744

@JohelEGP
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe your C++ modules build isn't recompiling some things, which is why it passes.

@mpusz
Copy link
Owner Author

@mpusz mpusz commented on 1c4f744 Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, but Ninja should take care of it, right?

Please sign in to comment.