-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi comparison (matrix, cube) #15
Merged
Merged
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
7d0bcdc
multi comparison (matrix, cube)
stan-donarise d9e601b
fix discovery cmp_labels
stan-donarise a5c428b
visavis_plot readme upd
stan-donarise 4c4f09a
fix re-render on scroll
stan-donarise d7a0f8d
typo
stan-donarise 29e21b4
plotly $mol_wire_sync; nplots_changed,legend_click
stan-donarise 5372901
delete unused bundles
stan-donarise de0dd4d
validate 'use_visavis_type' of multi jsons
stan-donarise 90be7c1
$mpds_visavis_plotly -> $mpds_visavis_lib_plotly_view
stan-donarise 2e6f0d8
multiple files at once
stan-donarise 11de864
add mem to auto
stan-donarise 1cf9b33
libs: `_` prefix instead `bundle` folders
stan-donarise 528da44
fix excess menu padding
stan-donarise 679e1d8
Update app.view.tree
stan-donarise d109067
$mol_wire_sync( this.$ ).
stan-donarise a43910f
remove excess `auto` overrides
stan-donarise File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
require \/mpds/visavis/lib/pca/bundle |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
namespace $ { | ||
|
||
export const $mpds_visavis_lib_pca = require('../mpds/visavis/lib/pca/bundle/pca.js') | ||
|
||
} |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
require \/mpds/visavis/lib/plotly/bundle |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
namespace $ { | ||
|
||
export const $mpds_visavis_lib_plotly = require('../mpds/visavis/lib/plotly/bundle/plotly.custom.min.js') | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
namespace $.$$ { | ||
|
||
$mol_style_define( $mpds_visavis_lib_plotly_view, { | ||
|
||
flex: { | ||
grow: 1 | ||
}, | ||
|
||
} ) | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
namespace $.$$ { | ||
|
||
export class $mpds_visavis_lib_plotly_view extends $.$mpds_visavis_lib_plotly_view { | ||
|
||
@ $mol_mem | ||
size() { | ||
if ( !this.view_rect() ) return | ||
const { width, height } = this.view_rect()! | ||
return { width, height } | ||
} | ||
|
||
@ $mol_mem | ||
Plotly_root() { | ||
if ( !this.size() ) return | ||
const { width, height } = this.size()! | ||
|
||
const plotly_root = $mol_wire_sync( document ).createElement( 'div' ) as HTMLElement | ||
const plotly_root_actual = $mol_wire_sync( $mpds_visavis_lib_plotly ).react( | ||
plotly_root, | ||
this.data(), | ||
{ ...this.layout(), width, height }, | ||
this.plot_options(), | ||
) | ||
|
||
return plotly_root_actual | ||
} | ||
|
||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
$mpds_visavis_plot_bar $mpds_visavis_plotly | ||
$mpds_visavis_plot_bar $mpds_visavis_lib_plotly_view | ||
plot_raw $mpds_visavis_plot_raw | ||
bar_click? null |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,5 @@ | ||
$mpds_visavis_plot_customscatter $mpds_visavis_plotly | ||
$mpds_visavis_plot_customscatter $mpds_visavis_lib_plotly_view | ||
plot_raw $mpds_visavis_plot_raw | ||
nplots_changed? null | ||
legend_click? null | ||
nplots 0 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 Какая-то странная ссылка. Она тут должна быть относительно текущего файла.
Возможно лучше было бы переименовать
pca.js
в_pca.js
(чтобы сборщик сам её не включал в бандл) и положить рядом, а потом подключит как-то так:require('./_pca.js')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
вроде сборщик устроен так, что у
require
должны быть полные пути?т.е. например в бандле (web.js) генерируется такой код
$node[ "../mpds/visavis/lib/pca/_pca.js" ]
а вот относительно текущего файла
require('./_pca.js')
- так не работаетThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Но полные пути должны с / начинаться. Выход из корня наверх не должен работать.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
вот https://github.com/stan-donarise/mam_mol/blob/master/build/build.node.ts#L937C1-L937C11
видимо из node_modules поднимается