Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add SPM and Improve Privacy Manifest support #11

Merged
merged 1 commit into from
May 7, 2024

Conversation

einsteinx2
Copy link
Contributor

Summary

  • Add SPM support
  • Fix parsing issue due to empty dict
  • Ensure manifest is included by package managers

Testing Plan

  • Was this tested locally? If not, explain why.
  • Confirmed in test apps

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add the Package.resolved to the ignore list

@einsteinx2 einsteinx2 force-pushed the feat/6413-improve-privacy-manifest-support branch from e252798 to 42d17bf Compare May 7, 2024 21:09
@einsteinx2
Copy link
Contributor Author

I'd add the Package.resolved to the ignore list

Good call, done.

Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@einsteinx2 einsteinx2 merged commit 2a57aa4 into development May 7, 2024
3 checks passed
@einsteinx2 einsteinx2 deleted the feat/6413-improve-privacy-manifest-support branch May 7, 2024 21:14
mparticle-automation added a commit that referenced this pull request May 7, 2024
# [8.2.0](v8.1.0...v8.2.0) (2024-05-07)

### Features

* Add SPM and Improve Privacy Manifest support ([#11](#11)) ([2a57aa4](2a57aa4))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 8.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants