[GV] Ignore editable annotations on GeckoView

[calixteman]

No description provided.

[calixteman]

/botio integrationtest

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/13a4e942e3cc793/output.txt

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/cff383abd7a2fdc/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/13a4e942e3cc793/output.txt

Total script time: 10.79 mins

• Integration Tests: FAILED

[Snuffleupagus]

Unfortunately I don't believe that this patch works as-is, since "normal" Firefox and GeckoView uses the same built pdf.mjs and pdf.worker.mjs files.
The only thing currently unique to GeckoView is the viewer, see

pdf.js/gulpfile.mjs

Lines 581 to 597 in b521885

	function createGVWebBundle(defines, options) {
	const viewerFileConfig = createWebpackConfig(
	defines,
	{
	filename: "viewer-geckoview.mjs",
	library: {
	type: "module",
	},
	},
	{
	defaultPreferencesDir: options.defaultPreferencesDir,
	}
	);
	return gulp
	.src("./web/viewer-geckoview.js", { encoding: false })
	.pipe(webpack2Stream(viewerFileConfig));
	}

Hence, in order for this to work, we'd need to introduce a new createGVMainBundle (similar to createMainBundle) and update the packaging code in mozilla-central to use that in GeckoView.

[moz-tools-bot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/cff383abd7a2fdc/output.txt

Total script time: 24.95 mins

• Integration Tests: FAILED

[calixteman]

Unfortunately I don't believe that this patch works as-is, since "normal" Firefox and GeckoView uses the same built pdf.mjs and pdf.worker.mjs files. The only thing currently unique to GeckoView is the viewer, see

pdf.js/gulpfile.mjs

Lines 581 to 597 in b521885

	function createGVWebBundle(defines, options) {
	const viewerFileConfig = createWebpackConfig(
	defines,
	{
	filename: "viewer-geckoview.mjs",
	library: {
	type: "module",
	},
	},
	{
	defaultPreferencesDir: options.defaultPreferencesDir,
	}
	);
	return gulp
	.src("./web/viewer-geckoview.js", { encoding: false })
	.pipe(webpack2Stream(viewerFileConfig));
	}

Hence, in order for this to work, we'd need to introduce a new createGVMainBundle (similar to createMainBundle) and update the packaging code in mozilla-central to use that in GeckoView.

Ah... yes you're right.