Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the fuzz tests (issue 19297) #19307

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

Snuffleupagus
Copy link
Collaborator

Reasons for removal:

  • These tests never generated any warnings from OSS-Fuzz, in over a year.

  • An error thrown during image decoding will lead to a broken/missing image, not a security problem.

  • These tests rely on the Jazzer.js library, which has a number of problems: It now causes failures in Node.js v23 in the CI tests, it's no longer being maintained upstream, and it lacks support for some (fairly common) CPU architectures.

@calixteman
Copy link
Contributor

There's another ref to fuzz stuff here:

pdf.js/eslint.config.mjs

Lines 355 to 363 in dfbd1d5

{
files: jsFiles("test/fuzz"),
rules: {
"import/no-unresolved": [
"error",
{ ignore: [".*/build/image_decoders/.*"] },
],
},
},

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

Reasons for removal:

 - These tests never generated any warnings from OSS-Fuzz, in over a year.

 - An error thrown during image decoding will lead to a broken/missing image, not a security problem.

 - These tests rely on the Jazzer.js library, which has a number of problems: It now causes failures in Node.js v23 in the CI tests, it's no longer being maintained upstream, and it lacks support for some (fairly common) CPU architectures.
@Snuffleupagus Snuffleupagus merged commit 115af68 into mozilla:master Jan 8, 2025
7 checks passed
@Snuffleupagus Snuffleupagus deleted the rm-fuzz-test branch January 8, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Dependency on jazzer.js breaks Linux builds
2 participants