Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let be more tolerant with predefined phone number format #19280

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Let be more tolerant with predefined phone number format #19280

merged 1 commit into from
Jan 6, 2025

Conversation

calixteman
Copy link
Contributor

The long US phone number format should be '(999) 999-9999' but the parenthesis can be omitted or the space replaced with a dash, ...

@calixteman calixteman linked an issue Jan 3, 2025 that may be closed by this pull request
[Bug]: Broken PDF fields on form #19274
Closed
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/af3b61abc0abad8/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9d4a8e4166397fc/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/9d4a8e4166397fc/output.txt

Total script time: 9.76 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/af3b61abc0abad8/output.txt

Total script time: 24.28 mins

  • Integration Tests: FAILED

Snuffleupagus
Snuffleupagus reviewed Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to run the unit-tests as well, such that the new test is being checked.

src/scripting_api/aform.js Outdated Show resolved Hide resolved
src/scripting_api/aform.js Outdated Show resolved Hide resolved
src/scripting_api/aform.js Outdated Show resolved Hide resolved
@calixteman
Let be more tolerant with predefined phone number format
3dd8752 
The long US phone number format should be '(999) 999-9999' but the parenthesis
can be omitted or the space replaced with a dash, ...
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fec6e5751694742/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3f5874a87e526f3/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/fec6e5751694742/output.txt

Total script time: 28.27 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/3f5874a87e526f3/output.txt

Total script time: 52.95 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

Snuffleupagus
Snuffleupagus approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you.

@calixteman calixteman merged commit af5beeb into mozilla:master Jan 6, 2025
9 checks passed
@calixteman calixteman deleted the issue19274 branch January 6, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
form-js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Broken PDF fields on form
3 participants
@calixteman @moz-tools-bot @Snuffleupagus