Reduce duplication when handling "DocException" and "PasswordRequest" messages #19259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… messages Rather than having to manually implement the exception-handling for the "DocException" message, we can instead re-use (and slightly extend) the existing `wrapReason` function since that one already does what we need. Furthermore, we can also simplify handling of the "PasswordRequest" message a little bit and again re-use the `wrapReason` function. Finally, the patch makes the following smaller changes: - Avoid needlessly re-creating exceptions in the `wrapReason` function. - Use a slightly shorter parameter name in the `wrapReason` function. - Remove the unused entries in the `CallbackKind`/`StreamKind` enumerations.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/08a575932054f88/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7ce50464ddeacb5/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/7ce50464ddeacb5/output.txt Total script time: 28.33 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/08a575932054f88/output.txt Total script time: 52.09 mins
|
timvandermeij
approved these changes
Dec 29, 2024
|
Nice simplification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than having to manually implement the exception-handling for the "DocException" message, we can instead re-use (and slightly extend) the existing
wrapReasonfunction since that one already does what we need.Furthermore, we can also simplify handling of the "PasswordRequest" message a little bit and again re-use the
wrapReasonfunction.Finally, the patch makes the following smaller changes:
wrapReasonfunction.wrapReasonfunction.CallbackKind/StreamKindenumerations.