Fix left offset when scrolling to search result #19232
Conversation
When computing the left offset of the highlighted text, we cannot use .offsetLeft because the text might have been scaled through CSS, and it needs to be taken into account. Use `.getClientRects()`/`.getBoundingClientRect()` instead, which will return measurements scaled appropriately.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/25c7ee343bb8668/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/25c7ee343bb8668/output.txt Total script time: 0.84 mins Published |
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6ce06766df96124/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/69ba8810e113299/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/6ce06766df96124/output.txt Total script time: 9.99 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/69ba8810e113299/output.txt Total script time: 24.32 mins
|
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e7af05c8780632a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d9f5be601147290/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/e7af05c8780632a/output.txt Total script time: 17.30 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/d9f5be601147290/output.txt Total script time: 26.91 mins
|
|
Thank you for fixing this! |
Fixes #19207. While approaches based on improving the font match in the text layer so that we don't need to scale help, they are not a complete solution because in some cases CSS scaling cannot be removed (such as in #18283).