Merge pull request #17172 from whimboo/webdriver-bidi

Switch Puppeteer tests from CDP to WebDriver BiDi
mozilla · Dec 8, 2023 · 07aa706 · 07aa706
2 parents 1510360 + d04d28a
commit 07aa706
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/test/test.mjs b/test/test.mjs
@@ -937,6 +937,10 @@ async function startBrowser({ browserName, headless, startUrl }) {
   }
 
   if (browserName === "firefox") {
+    // Run tests with the WebDriver BiDi protocol enabled only for Firefox for
+    // now given that for Chrome further fixes are needed first.
+    options.protocol = "webDriverBiDi";
+
     options.extraPrefsFirefox = {
       // avoid to have a prompt when leaving a page with a form
       "dom.disable_beforeunload": true,
@@ -1052,9 +1056,6 @@ async function closeSession(browser) {
       continue;
     }
     if (session.browser !== undefined) {
-      for (const page of await session.browser.pages()) {
-        await page.close();
-      }
       await session.browser.close();
     }
     session.closed = true;