Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch_configs, launchers: add Focus nightlies support (bug 1852620) #1452

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

zzzeid
Copy link
Collaborator

@zzzeid zzzeid commented Sep 12, 2023

  • add "focus" as an app option
  • add FocusNightlyConfigMixin and FocusConfig classes
  • add FocusLauncher class
  • add "fenix" to parametrized tests

@zzzeid zzzeid changed the title fetch_configs, launchers: add focus support (bug 1852620) fetch_configs, launchers: add Focus nightlies support (bug 1852620) Sep 12, 2023
@zzzeid zzzeid force-pushed the zeid/bug-1852620-add-focus-support branch from 703270d to 591baf1 Compare September 13, 2023 13:31
@zzzeid zzzeid force-pushed the zeid/bug-1556042-fenix-support branch 6 times, most recently from 1b04b69 to 350f960 Compare September 19, 2023 20:20
@zzzeid zzzeid force-pushed the zeid/bug-1852620-add-focus-support branch 3 times, most recently from 8118fee to 4626c11 Compare September 20, 2023 13:00
@zzzeid zzzeid marked this pull request as ready for review September 20, 2023 13:00
@zzzeid zzzeid requested a review from cgsheeh September 20, 2023 13:00
cgsheeh
cgsheeh previously approved these changes Sep 20, 2023
Base automatically changed from zeid/bug-1556042-fenix-support to main September 25, 2023 17:37
@zzzeid zzzeid dismissed cgsheeh’s stale review September 25, 2023 17:37

The base branch was changed.

- add "focus" as an app option
- add FocusNightlyConfigMixin and FocusConfig classes
- add FocusLauncher class
- add "fenix" to parametrized tests
@zzzeid zzzeid force-pushed the zeid/bug-1852620-add-focus-support branch from 4626c11 to d94f0bc Compare September 25, 2023 17:39
@zzzeid zzzeid requested a review from cgsheeh September 25, 2023 17:53
@zzzeid zzzeid merged commit 2fa869d into main Sep 25, 2023
17 checks passed
@zzzeid zzzeid deleted the zeid/bug-1852620-add-focus-support branch September 25, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants