Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch_configs, launchers: add Fenix nightlies support (bug 1556042) #1451

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

zzzeid
Copy link
Collaborator

@zzzeid zzzeid commented Sep 11, 2023

  • add "fenix" as an app option in the cli
  • update available arch options to include newer ones
  • Add FenixNightlyConfigMixin and FenixConfig classes
  • create new helper method AndroidBrowser.launch_browser
  • move adb.launch_fennec calls to adb.launch_application
  • create FenixLauncher class
  • parametrize existing Fennec tests and update to support Fenix
  • update cli help text
  • add fenix as supported app in docs

@zzzeid zzzeid force-pushed the zeid/bug-1556042-fenix-support branch 3 times, most recently from 235836d to 875504c Compare September 18, 2023 19:45
@zzzeid zzzeid force-pushed the zeid/bug-1556042-fenix-support branch 4 times, most recently from 1084c3e to 1b04b69 Compare September 19, 2023 20:15
@zzzeid zzzeid marked this pull request as ready for review September 19, 2023 20:16
@zzzeid zzzeid requested a review from cgsheeh September 19, 2023 20:17
- add "fenix" as an app option in the cli
- update available arch options to include newer ones
- Add FenixNightlyConfigMixin and FenixConfig classes
- create new helper method `AndroidBrowser.launch_browser`
- move `adb.launch_fennec` calls to `adb.launch_application`
- create FenixLauncher class
- parametrize existing Fennec tests and update to support Fenix
- update cli help text
- add fenix as supported app in docs
@zzzeid zzzeid force-pushed the zeid/bug-1556042-fenix-support branch from 1b04b69 to 350f960 Compare September 19, 2023 20:20
@zzzeid zzzeid marked this pull request as draft September 19, 2023 20:28
@zzzeid zzzeid marked this pull request as ready for review September 19, 2023 20:34
cgsheeh
cgsheeh previously approved these changes Sep 20, 2023
mozregression/cli.py Outdated Show resolved Hide resolved
mozregression/fetch_configs.py Show resolved Hide resolved
tests/unit/test_fetch_configs.py Outdated Show resolved Hide resolved
@zzzeid zzzeid merged commit aa86e13 into main Sep 25, 2023
17 checks passed
@zzzeid zzzeid deleted the zeid/bug-1556042-fenix-support branch September 25, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants