Bug 1932322 - Implement the new collection-enabled API
#3006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
force-pushed
the
collection-enabled
branch
2 times, most recently
from
92c1809
to
bcff07a
Compare
travis79
reviewed
Nov 21, 2024
glean-core/android/src/test/java/mozilla/telemetry/glean/private/EventMetricTypeTest.kt
Outdated
Show resolved
Hide resolved
|
Also, docs/changelog/etc. ofc |
badboy
force-pushed
the
collection-enabled
branch
6 times, most recently
from
a85c48b
to
e2a05ff
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3006 +/- ##
=======================================
Coverage 29.54% 29.54%
=======================================
Files 1 1
Lines 44 44
=======================================
Hits 13 13
Misses 31 31 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
badboy
force-pushed
the
collection-enabled
branch
from
8467e92
to
005c96f
Compare
This effectively deprecates `set_upload_enabled`.
No data is recorded for unknown or disabled pings.
badboy
force-pushed
the
collection-enabled
branch
from
005c96f
to
ccac839
Compare
travis79
approved these changes
Nov 27, 2024
| let pings_dir = self.get_pings_dir(data_path, None)?; | ||
|
|
||
| std::fs::remove_dir_all(&pings_dir)?; | ||
| create_dir_all(&pings_dir)?; | ||
| // TODO(bug 1932909): Refactor this into its own function |
|
Looks good to me, thanks for filing bugs for the TODOs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the mega PR changing the inner workings of Glean to support
collection-enabledandfollows-collection-enabledon pings, to independently control a subset of pings and whether they can get submitted.BREAKING CHANGE: This is definitely a huge breaking change.
2024-11-21: This is not yet fully ready for review
Some docs (though I probably will split some out to followups)docs in Bug 1933679 - Docs for collection-enabled mode #3013follows_collection_enabledfor pings glean_parser#776 (and release and update glean-parser)