Update AGP to v8.4.0

mozilla · May 6, 2024 · a31dd2a · a31dd2a
1 parent bc1582f
commit a31dd2a
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 14 deletions.
diff --git a/build.gradle b/build.gradle
@@ -117,22 +117,10 @@ ext.rustTargets += ext.nativeRustTarget
 subprojects {
     apply plugin: 'maven-publish'
 
-
     // Kotlin settings applicable to all modules.
     afterEvaluate {
-        if (it.hasProperty('android')) {
-            android {
-                // This shouldn't be needed anymore with AGP 8.1.0+
-                // https://kotlinlang.org/docs/gradle-configure-project.html#gradle-java-toolchains-support
-                compileOptions {
-                    sourceCompatibility rootProject.ext.build.jvmTargetCompatibility
-                    targetCompatibility rootProject.ext.build.jvmTargetCompatibility
-                }
-            }
-        }
         tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompile).all {
             kotlinOptions.allWarningsAsErrors = true
-            kotlin.jvmToolchain(rootProject.ext.build.jvmTargetCompatibility)
         }
     }
 

diff --git a/glean-core/android-native/build.gradle b/glean-core/android-native/build.gradle
@@ -8,8 +8,13 @@
 import groovy.json.JsonOutput
 
 apply plugin: 'com.android.library'
+apply plugin: 'kotlin-android'
 apply plugin: 'org.mozilla.rust-android-gradle.rust-android'
 
+kotlin {
+    jvmToolchain(rootProject.ext.build.jvmTargetCompatibility)
+}
+
 android {
     namespace "mozilla.telemetry.glean_native"
 

diff --git a/glean-core/android/build.gradle b/glean-core/android/build.gradle
@@ -28,6 +28,10 @@ File GLEAN_PING_SCHEMA_PATH = file("$rootDir/glean.1.schema.json")
 ext.allowGleanInternal = true
 ext.gleanNamespace = "mozilla.telemetry.glean"
 
+kotlin {
+    jvmToolchain(rootProject.ext.build.jvmTargetCompatibility)
+}
+
 android {
     compileSdkVersion rootProject.ext.build.compileSdkVersion
     namespace "mozilla.telemetry.glean"

diff --git a/gradle.properties b/gradle.properties
@@ -23,4 +23,4 @@ libLicense=MPL-2.0
 libLicenseUrl=https://www.mozilla.org/en-US/MPL/2.0/
 
 android.useAndroidX=true
-android.experimental.lint.version=8.3.0
+android.experimental.lint.version=8.4.0
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -5,7 +5,7 @@
 
 [versions]
 # AGP
-android-plugin = "8.0.2"
+android-plugin = "8.4.0"
 
 # Kotlin
 kotlin-compiler = "1.9.23"

diff --git a/samples/android/app/build.gradle b/samples/android/app/build.gradle
@@ -9,6 +9,10 @@ plugins {
 apply plugin: 'com.android.application'
 apply plugin: 'kotlin-android'
 
+kotlin {
+    jvmToolchain(rootProject.ext.build.jvmTargetCompatibility)
+}
+
 android {
     namespace "org.mozilla.samples.gleancore"
     compileSdkVersion rootProject.ext.build.compileSdkVersion