-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug 1771337 [wpt PR 34217] - Convert
popup=popup
to popup=auto
or…
… just `popup`, a=testonly Automatic update from web-platform-tests Convert `popup=popup` to `popup=auto` or just `popup` Per the [1] resolution, `popup=popup` has been renamed to `popup=auto`. Additionally, per the [2] resolution, "boolean-like" behavior is also supported, such that `<div popup>` means the same thing as `<div popup=auto>`. This CL implements both of these changes. Note that this CL has one case that still needs to be fixed: <div id=foo popup=invalid> <script> foo.popup === null; // false, should be true </script> To fix the above, I need to figure out how to specify the ReflectMissing and ReflectInvalid values so that they mean "null". [1] openui/open-ui#491 (comment) [2] openui/open-ui#533 (comment) Bug: 1307772 Change-Id: I6037c5322f7408ebd2c91690f89ecbc513c66bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3668816 Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Reviewed-by: Aaron Leventhal <[email protected]> Reviewed-by: Yuki Shiino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1009383} -- wpt-commits: 71cf6a42d3335c0c55cfe5b18c3b250c21a0ffbc wpt-pr: 34217
- Loading branch information
1 parent
a843c51
commit f6764f5
Showing
36 changed files
with
161 additions
and
151 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.