Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limited media-src CSP to report-only #15548

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

janbrasna
Copy link
Contributor

@janbrasna janbrasna commented Nov 22, 2024

One-line summary

Adds media-src CSP-RO rule to make up for RO-removed default-src wildcards.

Significant changes and points to review

Restricting defaults in #14897 may trigger some yet undefined policies, this specifically adds self+assets.m.o to media rules, to let it run in report-only for some time to see if that's the only host we need to add.

Issue / Bugzilla link

#15546

Testing

curl -I http://localhost:8000/de/

http://localhost:8000/de/firefox/built-for-you/?v=2

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.91%. Comparing base (8a8636c) to head (23a6da6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15548   +/-   ##
=======================================
  Coverage   78.90%   78.91%           
=======================================
  Files         158      158           
  Lines        8274     8275    +1     
=======================================
+ Hits         6529     6530    +1     
  Misses       1745     1745           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@janbrasna janbrasna marked this pull request as ready for review November 22, 2024 12:32
@janbrasna janbrasna requested a review from a team as a code owner November 22, 2024 12:32
@janbrasna janbrasna marked this pull request as draft November 22, 2024 13:49
@janbrasna janbrasna mentioned this pull request Nov 22, 2024
2 tasks
@janbrasna janbrasna changed the title Add media-src CSP Add limited media-src CSP to report-only Nov 22, 2024
@janbrasna janbrasna marked this pull request as ready for review November 22, 2024 14:01
Copy link
Member

@robhudson robhudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@robhudson robhudson merged commit f8d81da into mozilla:main Nov 22, 2024
5 checks passed
@janbrasna janbrasna deleted the fix/csp-defaults-reports branch November 22, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants