Refresh: Update gallery component (Fix #15481) #15533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephaniehobson
added
Review: XS
stephaniehobson
force-pushed
the
m24-gallery
branch
from
c612094
to
6f7e290
Compare
|
Updated to use the picture element. Height and width definitions can be a future improvement. |
- Add tag & tag icon - Add 3/4 size image - Add support for mobile image at a different aspect ratio - Add images and links where available - Move link from around tile to the title - use abosoltely positioned after to increase hit area - https://inclusive-components.design/cards/
stephaniehobson
force-pushed
the
m24-gallery
branch
from
6f7e290
to
a935087
Compare
craigcook
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
LGTM, and nice job on the aspect ratio switcheroo.
I know this isn't complete yet and you probably already have a to-do list for stuff to finish in a second pass. A few off the top of my head:
- Add links for the news section.
- Stringify text for l10n.
- Should the youtube link play in a modal like we do elsewhere? Maybe a post-launch P3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Updates to the gallery component to match the most recent design changes.
Significant changes and points to review
Issue / Bugzilla link
#15481
Testing
The font size will look weird if you review this before #15562 merges.