Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Elasticsearch 6.x #14206

Merged
merged 5 commits into from
May 28, 2020

Conversation

diox
Copy link
Member

@diox diox commented May 7, 2020

Because ES 6.x removed mapping types, move update_count and download_count in separate ES indexes. This requires a full reindex, including stats, but we need to create an entirely new cluster anyway.

ES 5.x compatibility is kept for now.

Fixes mozilla/addons#5609

Because ES 6.x removed mapping types, move update_count and download_count in
separate ES indexes. This requires a full reindex, including stats, but we need
to create an entirely new cluster anyway.

ES 5.x compatibility is kept for now.
@diox diox requested review from a team and willdurand and removed request for a team May 7, 2020 13:28
@@ -70,7 +80,16 @@ before_script:
- mysql --version
- node --version
- java -version
- curl -v http://localhost:9200/
- |
if [ $TOXENV == "es" ]; then

This comment was marked as resolved.

Copy link
Member

@willdurand willdurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a regression in the reindex command, specifically the --wipe option does not work anymore.

@diox
Copy link
Member Author

diox commented May 13, 2020

--wipe fixed in 2bcc682 but we're waiting a couple more weeks before merging this to get the best time to deploy this with ops.

Copy link
Member

@willdurand willdurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a conflict but the --wipe works and the rest seems to work as before so r+wc

@diox diox merged commit ec0d8f9 into mozilla:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to ElasticSearch 6
2 participants