Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jquery bench #477

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Jquery bench #477

wants to merge 2 commits into from

Conversation

zbraniecki
Copy link
Contributor

I was able to plug jquery into jsparagus parser bench!
I had to remove "use strict"; but except of that it just works. The perf is a bit slow for criterion and it increases the time beyond its preferred 5sec to get a reliable measurement - on my machine the test takes 50s, but I think it's a useful real-life benchmark.

The patch is on top of #476.

nbp
nbp reviewed Apr 23, 2020
View reviewed changes
Copy link
Collaborator

@nbp nbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is ok to me, however, I do not know about the licenses.
jQuery is MIT, and jsparagus is Apache 2.0 / MIT.

Can jQuery be sub-licensed as Apache 2.0, I would not think so. so we should probably exclude the benches directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbp nbp nbp left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zbraniecki @nbp