Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

sign verify #1

Merged
merged 10 commits into from
Apr 4, 2018
Merged

sign verify #1

merged 10 commits into from
Apr 4, 2018

Conversation

g-k
Copy link
Contributor

@g-k g-k commented Feb 27, 2018

WIP branch

TODO:

  • correct
    • CBORDecode cases pass (alg = -7 instead of -6) (edit: -7 for alg=ES256 is right, I just need to ignore the RHS in the cbor.me playground cbor.me off by one in comments for negative ints cbor/cbor.github.io#41)
    • wg /sign-tests pass
    • wg /ecdsa-examples pass
    • cose-rust test cases pass
    • delete or get the commented out cbor encode Marshal test cases passing
    • sign an addon and have cose-rust verify it
      • add cose-rust verify test example w/ cli args (usage: NSS_LIB_DIR=/usr/local/opt/nss/lib/ cargo run --example sign_verify -- $(cat ../../xpi_payload_hex) $(cat ../../xpi_sig_hex)) NB: :ulfr cleared up that we already have shared certs from the test vectors
  • feature complete for Addon Signing
    • Sign Message support
    • required algs
      • ES256, 384, 521
      • PS256
    • sign and verify multiple signatures
  • code quality / cleanup
    • don't return ok and err from Verify
    • don't return ToBeSigned from Sign
    • API docs https://godoc.org/gopkg.in/g-k/go-cose.v0
    • golint passes (going to leave the rust cose consts as is so they're easy to grep)
    • enable CI
    • rm stray debug prints
    • gofmt
    • better code coverage (say 80+%)
    • useful docstrings
    • fix the generated alg and common header tags (they should all be const-like or in a static index/map of some sort) they are tidier (everything using COSEAlgorithms array / not maintaining multiple sets of alg data)
    • extract errors to named vars
    • use go.mozilla.org for imports
    • usage docs
    • fix TODOs will split out separate issues for these

@g-k g-k force-pushed the sign-verify branch 2 times, most recently from 82fd5d8 to c1a00c2 Compare March 19, 2018 17:43
@g-k g-k force-pushed the sign-verify branch 4 times, most recently from 6ca0d11 to c2b21e6 Compare April 3, 2018 18:32
@g-k g-k merged commit ab7ab64 into master Apr 4, 2018
@g-k g-k deleted the sign-verify branch April 4, 2018 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant