Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query the whattrainisitnow release schedule API instead of hard-coding scheduled release dates #1464

Merged
merged 5 commits into from
May 15, 2024
Merged

Query the whattrainisitnow release schedule API instead of hard-coding scheduled release dates #1464

merged 5 commits into from
May 15, 2024

Conversation

gabrielBusta
Copy link
Member

Resolves #1461

@gabrielBusta gabrielBusta force-pushed the 1461 branch 3 times, most recently from fe8d39c to 8027361 Compare May 8, 2024 16:59
@gabrielBusta gabrielBusta changed the title Query the whattrainisitnow release schedule API instead of hard-coding future dates Query the whattrainisitnow release schedule API instead of hard-coding scheduled release dates May 8, 2024
@gabrielBusta gabrielBusta marked this pull request as ready for review May 8, 2024 17:05
@gabrielBusta gabrielBusta marked this pull request as draft May 8, 2024 20:39
@gabrielBusta gabrielBusta marked this pull request as ready for review May 10, 2024 22:34
@gabrielBusta gabrielBusta force-pushed the 1461 branch 3 times, most recently from 8a307a5 to 06aa096 Compare May 10, 2024 23:00
@gabrielBusta gabrielBusta requested a review from hneiva May 14, 2024 16:24
hneiva
hneiva approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@hneiva hneiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
A couple of nits, but none are required, I think it could be done in a subsequent PR.

api/src/shipit_api/admin/product_details.py Show resolved Hide resolved
api/src/shipit_api/admin/product_details.py Show resolved Hide resolved
api/src/shipit_api/admin/product_details.py Show resolved Hide resolved
@gabrielBusta
Copy link
Member Author

I went ahead and cleaned up these changes - thanks for the feedback!

@gabrielBusta gabrielBusta merged commit 55cd0cb into main May 15, 2024
6 checks passed
@gabrielBusta gabrielBusta deleted the 1461 branch May 15, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbrownmozilla gbrownmozilla gbrownmozilla approved these changes

@hneiva hneiva hneiva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query the"whattrainisitnow" release schedule API instead of hard-coding scheduled release dates
3 participants
@gabrielBusta @hneiva @gbrownmozilla