Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1934634 - Add linux-aarch64 to PRODUCT_TO_DESTINATIONS_REGEXES validation in bouncerscript #1101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bug 1934634 - Add linux-aarch64 to PRODUCT_TO_DESTINATIONS_REGEXES validation in bouncerscript #1101

wants to merge 2 commits into from

Conversation

gabrielBusta
Copy link
Member

@gabrielBusta gabrielBusta requested a review from a team December 6, 2024 22:15
jcristau
jcristau reviewed Dec 9, 2024
View reviewed changes
Copy link
Contributor

@jcristau jcristau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please track this in bugzilla.

@gabrielBusta
Copy link
Member Author

Ok I will track it on bug 1934634

@gabrielBusta gabrielBusta changed the title Add linux-aarch64 to PRODUCT_TO_DESTINATIONS_REGEXES validation in bouncerscript Bug 1934634 - Add linux-aarch64 to PRODUCT_TO_DESTINATIONS_REGEXES validation in bouncerscript Dec 9, 2024
@gabrielBusta gabrielBusta requested a review from jcristau December 9, 2024 19:05
@gabrielBusta gabrielBusta added the bug Something isn't working label Dec 9, 2024
@gabrielBusta gabrielBusta requested a review from a team December 9, 2024 19:08
bhearsum
bhearsum requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@bhearsum bhearsum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like

scriptworker-scripts/bouncerscript/src/bouncerscript/constants.py

Line 166 in 9ada102

BOUNCER_LOCATION_PLATFORMS = ["linux", "linux64", "osx", "win", "win64", "android-x86", "android", "win64-aarch64", "linux64-aarch64"]
will need an update as well.

@hneiva
Copy link
Contributor

hneiva commented Dec 10, 2024

😣 I really want to refactor these gigantic regexes.. Oh well, kick the ball down the road I guess 😁

bhearsum
bhearsum approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@bhearsum bhearsum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving, but let's hold off landing until you finish your staging runs, in case they uncover something.

@jcristau jcristau added enhancement New feature or request and removed bug Something isn't working labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhearsum bhearsum bhearsum approved these changes

@jcristau jcristau Awaiting requested review from jcristau

Assignees
No one assigned
Labels
bouncerscript enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrielBusta @hneiva @bhearsum @jcristau