scriptworker_client: properly handle signals in run_command #1030
Conversation
There was a problem hiding this comment.
If I understand correctly, this PR suggests that the combination of #324 + mozilla-releng/scriptworker#480 didn't ever work correctly in the first place?
| @@ -171,8 +171,8 @@ def test_get_log_filehandle(path, tmpdir): | |||
| True, | |||
| ), | |||
| ( | |||
| ["bash", "-c", ">&2 echo bar && echo foo && exit -11"], | |||
| 245, | |||
| ["bash", "-c", ">&2 echo bar && echo foo && kill -11 $$"], | |||
There was a problem hiding this comment.
Clearly this test was wrong originally. #324 also cites some real world testing, which might be good to do if you haven't already.
I think so, yes. I just resurrected this commit that I had sitting around locally since November, around the time of mozilla-releng/scriptworker#626 / https://bugzilla.mozilla.org/show_bug.cgi?id=1864413 which is also relevant for this. |
No description provided.